You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backport was not clean; a notable new change is in reflectionUtils.hpp (later JDK versions remove the affected class) - I am adding friend class FieldStream to InstanceKlass to accomodate for this.
rvansa
changed the title
8353175: Eliminate double iteration of stream in FieldDescriptor reinitialization
Backport 8353175: Eliminate double iteration of stream in FieldDescriptor reinitialization
Jul 22, 2025
rvansa
changed the title
Backport 8353175: Eliminate double iteration of stream in FieldDescriptor reinitialization
8353175: Eliminate double iteration of stream in FieldDescriptor reinitialization
Jul 22, 2025
👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@rvansa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
The reason will be displayed to describe this comment to others. Learn more.
The change looks fine. But you need to name the PRBackport f169fc5a99ee2b485e156c043134ab76b7e5ebd9, not just the changeset, to get it properly hooked up.
rvansa
changed the title
8353175: Eliminate double iteration of stream in FieldDescriptor reinitialization
Backport f169fc5a99ee2b485e156c043134ab76b7e5ebd9
Jul 30, 2025
openjdkbot
changed the title
Backport f169fc5a99ee2b485e156c043134ab76b7e5ebd9
8353175: Eliminate double iteration of stream in FieldDescriptor reinitialization
Jul 30, 2025
⚠️@rvansa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
https://bugs.openjdk.org/browse/JDK-8352075 is a fairly recent change (June 2025) in JDK 25 and touches core parts of the VM. We should stage this backport. Deferring to January as we'd have at least some real-world usage in JDK 25 at this point.
approvalRequires approval; will be removed when approval is receivedbackportPort of a pull request already in a different code baserfrPull request is ready for review
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rvansa
changed the title
openjdk
bot
added
the
approval
This backport is a partial fix for a performance regression and prerequisite for backport of openjdk/jdk#24847 (will be done through https://github.com/rvansa/jdk21u-dev/tree/refs/heads/rvansa/backport-8352075)
The backport was not clean; a notable new change is in
reflectionUtils.hpp(later JDK versions remove the affected class) - I am addingfriend class FieldStreamtoInstanceKlassto accomodate for this.Backport-of: f169fc5a99ee2b485e156c043134ab76b7e5ebd9
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2010/head:pull/2010$ git checkout pull/2010Update a local copy of the PR:
$ git checkout pull/2010$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2010/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2010View PR using the GUI difftool:
$ git pr show -t 2010Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2010.diff
Using Webrev
Link to Webrev Comment